Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range start should not be zero-based #33

Closed
marcelojgarcia opened this issue Nov 29, 2017 · 2 comments
Closed

Range start should not be zero-based #33

marcelojgarcia opened this issue Nov 29, 2017 · 2 comments

Comments

@marcelojgarcia
Copy link

In all examples provided, the range start of the page is zero-base, i.e. if there are 10 rows per page, data-table footer shows "Rows per page: 10 / 0-10 of N"
It should show "Rows per page: 10 / 1-10 of N"
@dhrytsenko
Copy link
Collaborator

Thanks, @marcelojgarcia. I will check

@dhrytsenko dhrytsenko mentioned this issue Dec 5, 2017
Merged
dhrytsenko added a commit that referenced this issue Dec 5, 2017
@dhrytsenko
Merge pull request #34 from dhrytsenko/issue-#33
907e0b8 
Fixed issue #33 and added new mixin
@dhrytsenko
Copy link
Collaborator

Fixed in PR #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelojgarcia @dhrytsenko