Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wibox horizontal position #23

Closed
wants to merge 1 commit into from
Closed

Fix wibox horizontal position #23

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2018

  • Current:
    screenshot-2018-03-10_10-43-37

  • With the change:
    screenshot-2018-03-10_10-42-19

@blueyed
Copy link
Owner

blueyed commented Mar 12, 2018

Thanks!
As per

awesome-cyclefocus/init.lua

Lines 921 to 922 in 679f74a

-- right-align.
x = math.ceil(wa.x + wa.width - w),
it is meant to be right-aligned (using a golden ratio), but I can see that centering it is what you might expect.

I think moving your patch up to this conditionally wbox:geometry call would be better though.

After all I think this could also be a callback that can be overridden then easily, since I actually like it to be on the right, getting out of the way of the master client which I have on the left usually.
But I think it's also useful to have it smaller etc.

I can see that the code needs some cleanup/improvements, e.g. wbox._for_screen is set but never used.

@blueyed blueyed mentioned this pull request Dec 27, 2018
@ghost ghost closed this by deleting the head repository Aug 13, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant