ExceptionInfo: join exception traceback with frame's stack #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
join-stack
branch
3 times, most recently
from
e89aec3
to
24a0864
Compare
blueyed
added a commit
that referenced
this pull request
Nov 8, 2019
Save original/current `pdb.set_trace` on the instance, not class. Tried to keep this minimal, more fixes forthcoming. Fixes pytest-dev#5228 properly (previously 9129ad3). Conflicts with pytest-dev/features due to: - cd10ee1 (minor, "improve header for _enter_pdb" (#21)) - 9659ce0 ("pdb: set excinfo in _postmortem_traceback, cut", #16; only a hack - WIP at #20 (ref: pytest-dev#6081))
blueyed
commented
Feb 3, 2020
| # XXX: remove any entries from the full tb previously ignored | ||
| # already. Without this, it would include e.g. src/pytest.py:101 | ||
| # or /usr/lib/python3.7/runpy.py:193 (previously unknown). | ||
| # The cutting needs some fix for generators anyway IIRC. |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pytest-dev#6081.
TODO:
sys.last_*should be deleted maybe (due to clean env for tests)