Skip to content

Commit

Permalink
monitor: const annotate intel_version_tlv_desc::type_str and API
Browse files Browse the repository at this point in the history
  • Loading branch information
evelikov-work authored and Vudentz committed Jan 19, 2024
1 parent 4630f3f commit 5380e63
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions monitor/intel.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,33 +171,33 @@ struct intel_version_tlv {
};

static void print_version_tlv_u32(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
print_field("%s(%u): 0x%8.8x", type_str, tlv->type, get_le32(tlv->val));
}

static void print_version_tlv_u16(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
print_field("%s(%u): 0x%4.4x", type_str, tlv->type, get_le16(tlv->val));
}

static void print_version_tlv_u8(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
print_field("%s(%u): 0x%2.2x", type_str, tlv->type, get_u8(tlv->val));
}

static void print_version_tlv_enabled(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
print_field("%s(%u): %s(%u)", type_str, tlv->type,
tlv->val[0] ? "Enabled" : "Disabled",
tlv->val[0]);
}

static void print_version_tlv_img_type(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
const char *str;

Expand All @@ -217,34 +217,34 @@ static void print_version_tlv_img_type(const struct intel_version_tlv *tlv,
}

static void print_version_tlv_timestamp(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
print_field("%s(%u): %u-%u", type_str, tlv->type,
tlv->val[1], tlv->val[0]);
}

static void print_version_tlv_min_fw(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
print_field("%s(%u): %u-%u.%u", type_str, tlv->type,
tlv->val[0], tlv->val[1], 2000 + tlv->val[2]);
}

static void print_version_tlv_otp_bdaddr(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
packet_print_addr(type_str, tlv->val, 0x00);
}

static void print_version_tlv_unknown(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
print_field("%s(%u): ", type_str, tlv->type);
packet_hexdump(tlv->val, tlv->len);
}

static void print_version_tlv_mfg(const struct intel_version_tlv *tlv,
char *type_str)
const char *type_str)
{
uint16_t mfg_id = get_le16(tlv->val);

Expand All @@ -254,8 +254,8 @@ static void print_version_tlv_mfg(const struct intel_version_tlv *tlv,

static const struct intel_version_tlv_desc {
uint8_t type;
char *type_str;
void (*func)(const struct intel_version_tlv *tlv, char *type_str);
const char *type_str;
void (*func)(const struct intel_version_tlv *tlv, const char *type_str);
} intel_version_tlv_table[] = {
{ 16, "CNVi TOP", print_version_tlv_u32 },
{ 17, "CNVr TOP", print_version_tlv_u32 },
Expand Down Expand Up @@ -365,7 +365,7 @@ static void read_version_rsp(uint16_t index, const void *data, uint8_t size)

static void read_version_cmd(uint16_t index, const void *data, uint8_t size)
{
char *str;
const char *str;
uint8_t type;

/* This is the legacy read version command format and no further action
Expand Down

0 comments on commit 5380e63

Please sign in to comment.