Skip to content

Commit

Permalink
adapter: Fix addr_type for smp_irk/ltk_info/link_key
Browse files Browse the repository at this point in the history
According to BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 3,
Part H, 2.4.24/2.4.25, The LE LTK and BR/EDR link keys can be
converted between each other, so the addr type can be either
BREDR or LE, so fix it.
  • Loading branch information
xiaoyao888888 authored and Vudentz committed Dec 11, 2023
1 parent 87477b7 commit d5536e0
Showing 1 changed file with 14 additions and 6 deletions.
20 changes: 14 additions & 6 deletions src/adapter.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ static GSList *conn_fail_list = NULL;

struct link_key_info {
bdaddr_t bdaddr;
uint8_t bdaddr_type;
unsigned char key[16];
uint8_t type;
uint8_t pin_len;
Expand Down Expand Up @@ -3964,7 +3965,9 @@ static bool is_blocked_key(uint8_t key_type, uint8_t *key_value)
return false;
}

static struct link_key_info *get_key_info(GKeyFile *key_file, const char *peer)
static struct link_key_info *get_key_info(GKeyFile *key_file, const char *peer,
uint8_t bdaddr_type)

{
struct link_key_info *info = NULL;
char *str;
Expand All @@ -3976,6 +3979,7 @@ static struct link_key_info *get_key_info(GKeyFile *key_file, const char *peer)
info = g_new0(struct link_key_info, 1);

str2ba(peer, &info->bdaddr);
info->bdaddr_type = bdaddr_type;

if (!strncmp(str, "0x", 2))
str2buf(&str[2], info->key, sizeof(info->key));
Expand Down Expand Up @@ -4343,7 +4347,7 @@ static void load_link_keys(struct btd_adapter *adapter, GSList *keys,
struct link_key_info *info = l->data;

bacpy(&key->addr.bdaddr, &info->bdaddr);
key->addr.type = BDADDR_BREDR;
key->addr.type = info->bdaddr_type;
key->type = info->type;
memcpy(key->val, info->key, 16);
key->pin_len = info->pin_len;
Expand Down Expand Up @@ -4598,14 +4602,18 @@ static void load_conn_params(struct btd_adapter *adapter, GSList *params)
btd_error(adapter->dev_id, "Load connection parameters failed");
}

static uint8_t get_le_addr_type(GKeyFile *keyfile)
static uint8_t get_addr_type(GKeyFile *keyfile)
{
uint8_t addr_type;
char *type;

/* The AddressType is written to file only When dev->le is
* set to true, as referenced in the update_technologies().
* Therefore, When type is NULL, it default to BDADDR_BREDR.
*/
type = g_key_file_get_string(keyfile, "General", "AddressType", NULL);
if (!type)
return BDADDR_LE_PUBLIC;
return BDADDR_BREDR;

if (g_str_equal(type, "public"))
addr_type = BDADDR_LE_PUBLIC;
Expand Down Expand Up @@ -4914,9 +4922,9 @@ static void load_devices(struct btd_adapter *adapter)
g_clear_error(&gerr);
}

key_info = get_key_info(key_file, entry->d_name);
bdaddr_type = get_addr_type(key_file);

bdaddr_type = get_le_addr_type(key_file);
key_info = get_key_info(key_file, entry->d_name, bdaddr_type);

ltk_info = get_ltk_info(key_file, entry->d_name, bdaddr_type);

Expand Down

0 comments on commit d5536e0

Please sign in to comment.