Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-bluetooth will not work properly after turn off in UI at first time. #162

Closed
andychi117 opened this issue Jun 23, 2021 · 2 comments
Closed

gnome-bluetooth will not work properly after turn off in UI at first time. #162

andychi117 opened this issue Jun 23, 2021 · 2 comments

Comments

@andychi117
Copy link

Hi,
When I turned off Bluetooth in gnome UI then turn it on again, devices are not listed.
[test environment]
OS: ubuntu 20.04
kernel: 5.13-rc6

Below is the bug in gnome-bluetooth and Benjamin send a patch to linux-bluetooth.
Bug from gnome-bluetooth:
https://gitlab.gnome.org/GNOME/gnome-bluetooth/-/issues/38
Patch discussion in linux-bluetooth:
https://marc.info/?t=162004758900003&r=1&w=2

Can we merge this patch back to bluez?
Thanks.
benzea pushed a commit to benzea/bluez that referenced this issue Jun 23, 2021
rfkill: Fix reading from rfkill socket
28dbf57 
The kernel will always send exactly one event, but the size of the
passed struct will depend on the length of the submitted read() and the
kernel version. i.e. the interface can be extended and we need to expect
for a read to be longer than expected if we ask for it.

Fix this by only requesting the needed length and explicitly check the
length against the V1 version of the structure to make the code a bit
more future proof in case the internal copy of the struct is updated to
contain new fields.

Closes: bluez#162
@benzea benzea mentioned this issue Jun 23, 2021
Closed
@validatedev
Copy link

validatedev commented Jun 23, 2021 •
edited
Loading

The experience was flawless (no issue like this one) with Ubuntu 20.04, but on Ubuntu 21.04 the problem is happening. Maybe the new kernel raises a new issue.

@Vudentz
Copy link
Contributor

Vudentz commented Jun 23, 2021

Fix merged: https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=c939747f543a76ffd556312f753cf9d36c047c94

@Vudentz Vudentz closed this as completed Jun 23, 2021
@jason77-wang jason77-wang mentioned this issue Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rfkill: Fix reading from rfkill socket benzea/bluez
3 participants
@Vudentz @andychi117 @validatedev