Skip to content

Commit

Permalink
Remove seemingly incorrect BAD_SEMANTICS_SIZE pre-compile constant
Browse files Browse the repository at this point in the history
- If a tx is over 100 in size, it doesn't seem right that we should swap it with the prior block which we saw with bad semantics, and clear that prior block.
  • Loading branch information
who-biz committed Jul 15, 2019
1 parent 3ab0bd4 commit 80a7341
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions src/cryptonote_core/cryptonote_core.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ DISABLE_VS_WARNINGS(4355)

#define MERROR_VER(x) MCERROR("verify", x)

#define BAD_SEMANTICS_TXES_MAX_SIZE 100

namespace cryptonote
{
const command_line::arg_descriptor<bool, false> arg_testnet_on = {
Expand Down Expand Up @@ -635,11 +633,6 @@ namespace cryptonote
tvc.m_verifivation_failed = true;
bad_semantics_txes_lock.lock();
bad_semantics_txes[0].insert(tx_hash);
if (bad_semantics_txes[0].size() >= BAD_SEMANTICS_TXES_MAX_SIZE)
{
std::swap(bad_semantics_txes[0], bad_semantics_txes[1]);
bad_semantics_txes[0].clear();
}
bad_semantics_txes_lock.unlock();
return false;
}
Expand Down

0 comments on commit 80a7341

Please sign in to comment.