Add a feature to explicitly enable "std" #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
approved these changes
Aug 30, 2020
If you know you need "std", e.g. relying on default `S = RandomState`, then you can enable this feature to force it on, bypassing target detection. This may help scenarios where `autocfg` fails detection, like issue indexmap-rs#144, but at the very least it will speed up the build script by avoiding extra `rustc` invocations.
cuviper
force-pushed
the
explicit-std
branch
from
c0ebc48
to
4de0dcf
Compare
|
OK, I'm going to release this as 1.5.2. |
carols10cents
added a commit
to integer32llc/arrow-rs
that referenced
this pull request
Dec 3, 2021
The indexmap crate uses the autocfg crate to do target detection to determine whether `std` is available. Arrow isn't targeting `no_std` environments, so the target detection isn't necessary. This might save some build time. indexmap-rs/indexmap#145
carols10cents
added a commit
to integer32llc/arrow-rs
that referenced
this pull request
Dec 3, 2021
The indexmap crate uses the autocfg crate to do target detection to determine whether `std` is available. Arrow isn't targeting `no_std` environments, so the target detection isn't necessary. This might save some build time. indexmap-rs/indexmap#145
alamb
pushed a commit
to apache/arrow-rs
that referenced
this pull request
Dec 4, 2021
* Disable default features of chrono; only enable features needed Chrono's default features contain "oldtime", which is deprecated. According to [the docs](https://docs.rs/chrono/0.4.19/chrono/#duration), > new code should disable the oldtime feature and use the > chrono::Duration type instead. The oldtime feature is enabled by > default for backwards compatibility, but future versions of Chrono > are likely to remove the feature entirely. so follow that recommendation by setting default-features to false. And actually, only Arrow needs the "clock" feature, so all the other features can stay off too to minimize the feature set that projects depending on arrow or parquet are forced to enable. * Explicitly enable indexmap's "std" feature The indexmap crate uses the autocfg crate to do target detection to determine whether `std` is available. Arrow isn't targeting `no_std` environments, so the target detection isn't necessary. This might save some build time. indexmap-rs/indexmap#145
alamb
pushed a commit
to apache/arrow-rs
that referenced
this pull request
Dec 9, 2021
* Disable default features of chrono; only enable features needed Chrono's default features contain "oldtime", which is deprecated. According to [the docs](https://docs.rs/chrono/0.4.19/chrono/#duration), > new code should disable the oldtime feature and use the > chrono::Duration type instead. The oldtime feature is enabled by > default for backwards compatibility, but future versions of Chrono > are likely to remove the feature entirely. so follow that recommendation by setting default-features to false. And actually, only Arrow needs the "clock" feature, so all the other features can stay off too to minimize the feature set that projects depending on arrow or parquet are forced to enable. * Explicitly enable indexmap's "std" feature The indexmap crate uses the autocfg crate to do target detection to determine whether `std` is available. Arrow isn't targeting `no_std` environments, so the target detection isn't necessary. This might save some build time. indexmap-rs/indexmap#145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you know you need "std", e.g. relying on default
S = RandomState,then you can enable this feature to force it on, bypassing target
detection. This may help scenarios where
autocfgfails detection, likeissue #144, but at the very least it will speed up the build script by
avoiding extra
rustcinvocations.