Update indexmap dependency & fix compiler warnings #758
+8
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
reviewed
Jan 12, 2024
cuviper
reviewed
Jan 12, 2024
Co-authored-by: Josh Stone <cuviper@gmail.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
|
Also this PR fixed an old problem with indexmap #466. |
cuviper
reviewed
Jan 18, 2024
| @@ -168,7 +168,7 @@ impl<F: Future> common::Drive<F> for FuturesOrdered<F> { | |||
| } | |||
|
|
|||
| fn push(&mut self, future: F) { | |||
| FuturesOrdered::push(self, future) | |||
| FuturesOrdered::push_back(self, future) | |||
There was a problem hiding this comment.
This needs futures-util v0.3.22 (or later).
| @@ -174,7 +174,7 @@ mod tests { | |||
| let mut r = HasherRng::default(); | |||
| match super::sample_floyd2(&mut r, 2) { | |||
| [0, 1] | [1, 0] => (), | |||
| err => panic!("{err:?}"), | |||
| err => panic!("{:?}", err), | |||
There was a problem hiding this comment.
Ah, the previous format would be fine if the crate upgraded to 2021 edition -- which it could do with the new MSRV, but that might be a bigger change than desired right now.
| @@ -91,7 +91,6 @@ tower-test = { version = "0.4", path = "../tower-test" } | |||
| tracing = { version = "0.1.2", default-features = false, features = ["std"] } | |||
| tracing-subscriber = { version = "0.3", default-features = false, features = ["fmt", "ansi"] } | |||
| http = "0.2" | |||
| lazy_static = "1.4.0" | |||
There was a problem hiding this comment.
I think this is needed to fix the minimal version used in tests, per #670, or else you get:
error: cannot find macro `__lazy_static_internal` in this scope
--> [...]/sharded-slab-0.1.1/src/tid.rs:32:1
|
32 | / lazy_static! {
33 | | static ref REGISTRY: Registry = Registry {
34 | | next: AtomicUsize::new(0),
35 | | free: Mutex::new(VecDeque::new()),
36 | | };
37 | | }
| |_^
|
= note: this error originates in the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#741 proposes changing
get_ready_index_mut's signature, but that would be a semver breaking change, so can wait for0.5Also remove unused lazy_static dev dependency