Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space from file names #78

Merged
merged 2 commits into from
May 2, 2023
Merged

Remove space from file names #78

merged 2 commits into from
May 2, 2023

Conversation

xander-zitara
Copy link
Contributor

@xander-zitara xander-zitara commented May 2, 2023

The space introduced with the addition of the spare kernels directory breaks Rust builds in Bazel (which doesn't like spaces!) for any project depending transitively on matrixmultiply. I have replaced the space in spare kernels (making it spare_kernels) to fix this problem, and confirmed that this crate builds and tests pass.

Fixes #79

@bluss
Copy link
Owner

bluss commented May 2, 2023

Do you know why a modern tool has such strange restrictions, and who uses Bazel?

@xander-zitara
Copy link
Contributor Author

Do you know why a modern tool has such strange restrictions, and who uses Bazel?

Bazel is somewhat common for large projects that use multiple languages (imagine some code base with any combination of Rust, C++, Go, Java) in my experience. I don't know the reason for the restriction.

@bluss
Copy link
Owner

bluss commented May 2, 2023

Thanks. I'll squash merge this to clean up the history. And make a note that Bazel is quirky.

v 0.3.7 released

@bluss bluss merged commit 496f08a into bluss:master May 2, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel: link or target filename contains space
2 participants