impl Error for EncodeUtf8Error, and add a fallback description method #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when not using std
bluss
reviewed
Feb 5, 2017
src/char.rs
Outdated
|
|
||
| #[cfg(not(feature = "std"))] | ||
| impl EncodeUtf8Error { | ||
| fn description(&self) -> &str { |
There was a problem hiding this comment.
This method seems to be extra, it's not needed?
There was a problem hiding this comment.
The Error trait is a std-only trait. I added this method as a fallback for when std is not enabled.
The ascii crate uses a similar technique with its error types.
|
Right, it wasn't pub so I didn't understand. The intrinsic method must not be inversely conditional, that is not compatible with crate versioning and features. "std" is an additive feature and can not take anything away. Could just just put the string definition without const inside the intrinsic description method? Thanks |
…itional on no std
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.