Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-124 Enhanced docker files for remote nodes #46

Merged
merged 2 commits into from
Feb 29, 2020
Merged

Conversation

matteyu
Copy link
Collaborator

@matteyu matteyu commented Feb 28, 2020

-changed docker-compose to have the container restart automatically after crashing
-added rotating logs
-exposed the two ports in dockerfile
-added a build step to docker-compose so you don't need to execute that command seperately

@matteyu matteyu requested a review from ebruck February 28, 2020 17:05
Copy link
Contributor

@ebruck ebruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please make sure the commit message has a Jira task number:

CM-XYZ Enhanced docker files for remote nodes (#46)

@matteyu matteyu changed the title Enhanced docker files for remote nodes CM-124 Enhanced docker files for remote nodes Feb 29, 2020
@matteyu matteyu merged commit f83aaf8 into devel Feb 29, 2020
@matteyu matteyu deleted the task/milagan/cm-124 branch March 18, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants