Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-339 Add Faucet Module #60

Merged
merged 5 commits into from
Mar 10, 2020
Merged

CM-339 Add Faucet Module #60

merged 5 commits into from
Mar 10, 2020

Conversation

njmurarka
Copy link
Contributor

Example use of the faucet:

blzcli tx faucet mintfor $(blzcli keys show neeraj -a) --from vuser --gas-prices 0.01bnt

Has been tested in a single validator environment only.

@njmurarka njmurarka requested a review from ebruck March 10, 2020 07:45
@njmurarka
Copy link
Contributor Author

njmurarka commented Mar 10, 2020

@ebruck Please review and approve ASAP. Need this urgently for a testnet update.

@@ -24,7 +24,7 @@ ldflags = -X github.com/cosmos/cosmos-sdk/version.Name=BluzelleService \
-X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \
-X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags_comma_sep),cosmos-sdk $(COSMOS_SDK)"

BUILD_FLAGS := -tags "$(build_tags)" -ldflags '$(ldflags)'
BUILD_FLAGS := -tags "$(build_tags)" -ldflags '$(ldflags)' -tags faucet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this update the version info as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it does.

Copy link
Contributor

@ebruck ebruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do an interactive rebase to collapse all the diffs. It's hard to tell what is going on.

@njmurarka
Copy link
Contributor Author

Please do an interactive rebase to collapse all the diffs. It's hard to tell what is going on.

Done.

@ebruck ebruck self-requested a review March 10, 2020 21:55
@njmurarka njmurarka merged commit f4e0529 into devel Mar 10, 2020
@ebruck ebruck deleted the task/njmurarka/cm-339 branch March 10, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants