todo notes

crud/crud.cpp

@@ -983,6 +983,7 @@ crud::is_caller_a_writer(const bzn::caller_id_t& caller_id, const Json::Value& p
     }
 
     // A node may be issuing an operation such as delete for key expiration...
+    // TODO: this may need to compare against all recent peers, not just current ones
     for (const auto& peer_uuid : *this->pbft->peers()->current())
     {
         if (peer_uuid.uuid == boost::trim_copy(caller_id))

pbft/operations/pbft_memory_operation.cpp

@@ -139,12 +139,14 @@ pbft_memory_operation::is_preprepared() const
 bool
 pbft_memory_operation::is_ready_for_commit() const
 {
+    // TODO: may have to count based only on uuids that are still in the peers list
     return this->has_request() && this->is_preprepared() && this->prepares_seen.size() >= pbft::honest_majority_size(this->peers->current()->size());
 }
 
 bool
 pbft_memory_operation::is_ready_for_execute() const
 {
+    // TODO: may have to count based only on uuids that are still in the peers list
     return this->is_prepared() && this->commits_seen.size() >= pbft::honest_majority_size(this->peers->current()->size());
 }
 

pbft/pbft.cpp

@@ -875,7 +875,7 @@ pbft::quorum_size() const
 size_t
 pbft::max_faulty_nodes() const
 {
-    return this->peers_beacon->current()->size()/3;
+    return (this->peers_beacon->current()->size()-1)/3;
 }
 
 void