This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
DEV-20 Adding version tagging to release. Create OSX package. Make re… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lease branch master and set 0.1.x release version
ebruck
reviewed
May 15, 2018
|
|
||
| #pragma once | ||
|
|
||
| #define SWARM_VERSION "@PROJECT_VERSION@" |
There was a problem hiding this comment.
I don't see this version string replacing the one in include/bluzelle.hpp.
The daemon has a --version option.
ebruck
reviewed
May 15, 2018
CMakeLists.txt
Outdated
| include(swarm_version.cmake) | ||
| configure_file(${PROJECT_SOURCE_DIR}/swarm_version.hpp.in ${CMAKE_BINARY_DIR}/swarm_version.hpp) | ||
| message("Build version ${PROJECT_VERSION}") | ||
|
|
There was a problem hiding this comment.
You need to configure the file into a temp like so:
configure_file(${PROJECT_SOURCE_DIR}/swarm_version.hpp.in ${CMAKE_BINARY_DIR}/swarm_version.hpp.tmp)
then:
execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_BINARY_DIR}/swarm_version.hpp.tmp ${CMAKE_BINARY_DIR}/swarm_version.hpp)
execute_process(COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_BINARY_DIR}/swarm_version.hpp.tmp)
This allows the daemon to include the header and only triggering a compile if the version changes since we need to include it for the --version option.
added 4 commits
May 15, 2018 13:06
ebruck
approved these changes
May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lease branch master and set 0.1.x release version