This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
KEP-1552 Get Peer Info creates correct ESR request data #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rnistuk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ebruck
suggested changes
Jul 3, 2019
utils/esr_peer_info.cpp
Outdated
| std::string result{parameter}; | ||
| result.insert(result.size(), PADDING_REQUIRED, '0'); | ||
| return result; | ||
| static const size_t REQUIRED_SIZE_MULTIPLE{64}; |
There was a problem hiding this comment.
please stop using statics... move to unnamed namespaces.
You incur a performance hit for every call of a function.
utils/esr_peer_info.cpp
Outdated
| const std::string | ||
| data_string_for_get_peer_info(const std::string &swarm_id, const std::string &peer_id) | ||
| { | ||
| static const off_t PARAMETER_OFFSET{64}; |
There was a problem hiding this comment.
All statics moved to anonymous namespace where appropriate
utils/esr_peer_info.cpp
Outdated
| // TODO: replace this with a function that uses the ABI to create the request data | ||
| // data_string_for_get_peer_info has been moved out of the anonymous namespace to make it possible to | ||
| // unit test directly. | ||
| const std::string | ||
| data_string_for_get_peer_info(const std::string &swarm_id, const std::string &peer_id) |
utils/esr_peer_info.cpp
Outdated
| static const auto PEER_INFO_ABI{str_to_json(GET_PEER_INFO_ABI)}; | ||
| static const auto GET_PEER_INFO_SIGNATURE{PEER_INFO_ABI["signature"].asCString() + 2}; | ||
| static const auto GET_PEER_INFO_SIGNATURE{PEER_INFO_ABI["signature"].asString()}; |
ebruck
reviewed
Jul 3, 2019
utils/esr_peer_info.cpp
Outdated
| @@ -394,8 +394,8 @@ namespace | |||
| const std::string | |||
| data_string_for_get_peers(const std::string &swarm_id) | |||
| { | |||
| static const auto NODE_LIST_ABI = str_to_json(GET_NODE_LIST_ABI); | |||
| static const auto GET_PEERS_ADDRESS{NODE_LIST_ABI["signature"].asCString() + 2}; // 0x46e76d8b -> 46e76d8b | |||
| const auto NODE_LIST_ABI = str_to_json(GET_NODE_LIST_ABI); | |||
There was a problem hiding this comment.
you were better as a static here... why don;t you add a json version to the consts instead of converting it
ebruck
reviewed
Jul 3, 2019
utils/esr_peer_info.cpp
Outdated
| static const off_t PARAMETER_OFFSET{64}; | ||
| static const auto PEER_INFO_ABI{str_to_json(GET_PEER_INFO_ABI)}; | ||
| static const auto GET_PEER_INFO_SIGNATURE{PEER_INFO_ABI["signature"].asString()}; | ||
| const auto PEER_INFO_ABI{str_to_json(GET_PEER_INFO_ABI)}; |
ebruck
approved these changes
Jul 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.