Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create santiago.json #1 #244

Merged
merged 3 commits into from
Nov 28, 2017
Merged

Create santiago.json #1 #244

merged 3 commits into from
Nov 28, 2017

Conversation

SantiCF
Copy link
Contributor

@SantiCF SantiCF commented Oct 30, 2017

No description provided.

@arminkhoshbin arminkhoshbin mentioned this pull request Nov 1, 2017
Closed
@arminkhoshbin
Copy link
Collaborator

Thanks for your contribution @SantiCF!
The tests are failing because of the English translation in the JSON file. Can you please remove the English translation from JSON file and update the existing james.json to include the Spanish translation?

Tag me here when it's done and I'll happily merge this for you :)

@arminkhoshbin arminkhoshbin merged commit 003b79c into bluzi:master Nov 28, 2017
@arminkhoshbin
Copy link
Collaborator

Fantastic! Thanks very much @SantiCF
Merged #1

@SantiCF SantiCF deleted the santiago branch November 28, 2017 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminkhoshbin arminkhoshbin arminkhoshbin approved these changes

Assignees
No one assigned
Labels
requires-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SantiCF @arminkhoshbin