Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to check if names are not duplicate #78

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Conversation

jhalaa
Copy link
Contributor

@jhalaa jhalaa commented Oct 24, 2017

No description provided.

@bluzi
Copy link
Owner

bluzi commented Oct 24, 2017

Awesome! thanks
merged #40

@jhalaa jhalaa deleted the patch-1 branch October 24, 2017 20:26
@jhalaa
Copy link
Contributor Author

jhalaa commented Oct 24, 2017

Thanks for merging :)
Can I also take a look at this issue?

  • Test all language codes against a ISO-639-3 language codes, to make sure they all valid

I was thinking of adding this npm package to get all the ISO-639-3 language codes. This would make it easier to maintain and extensible.
Do you think this is a good idea or would it be better to keep the static data and not use any external dependencies?

@bluzi bluzi mentioned this pull request Oct 24, 2017
@bluzi
Copy link
Owner

bluzi commented Oct 24, 2017

Hey @jhalaa,
I think it's a great idea, can't wait to merge it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants