Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Wormholy fail Archive #66

Merged
merged 2 commits into from
Nov 11, 2022
Merged

[Bug] Fix Wormholy fail Archive #66

merged 2 commits into from
Nov 11, 2022

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Oct 27, 2022

What happened

Fix archive failing because Wormholy wants a Signing Certificate.

Insight

pmusolino/Wormholy#117
https://stackoverflow.com/a/74129238/3736373

Proof of Work

https://github.com/blyscuit/kmm-swiftUI-IC/actions/runs/3334901886

Screen Shot 2022-10-27 at 14 10 40

@blyscuit blyscuit added bug Something isn't working type: chore labels Oct 27, 2022
@blyscuit blyscuit added this to the 0.0.1 milestone Oct 27, 2022
@blyscuit blyscuit self-assigned this Oct 27, 2022
@blyscuit blyscuit marked this pull request as ready for review October 27, 2022 07:12
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

🧛 shared Code Coverage: 72.41%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Podfile
Podfile.lock

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Oct 27, 2022

Current coverage for Survey is 55.36%

No files affecting coverage found


Powered by xcov

Generated by 🚫 Danger

blyscuit added a commit that referenced this pull request Nov 8, 2022
Co-authored-by: Su Ho <hovansu.it@gmail.com>
@blyscuit blyscuit requested a review from suho November 8, 2022 02:59
blyscuit added a commit that referenced this pull request Nov 8, 2022
blyscuit added a commit that referenced this pull request Nov 8, 2022
blyscuit added a commit that referenced this pull request Nov 8, 2022
blyscuit added a commit that referenced this pull request Nov 8, 2022
[#66] Remove testing branch in workflow

Co-authored-by: Su Ho <hovansu.it@gmail.com>
blyscuit added a commit that referenced this pull request Nov 8, 2022
[#66] Remove testing branch in workflow

Co-authored-by: Su Ho <hovansu.it@gmail.com>
@blyscuit blyscuit merged commit 0a61beb into develop Nov 11, 2022
@blyscuit blyscuit deleted the bug/cicd-fix-wormholy branch November 11, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type: chore
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants