This repository has been archived by the owner on Jun 21, 2018. It is now read-only.
Add page number to breadcrumb #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
okkez
commented
Feb 9, 2016
okkez
commented
- welcome#index
- category#show
- post#show
| @@ -1,5 +1,6 @@ | |||
| - content_for(:rel_next_prev_link_tags) { rel_next_prev_link_tags(@posts) } | |||
| - breadcrumb :category, @category | |||
| - breadcrumb :category_page, @category if params[:page] | |||
There was a problem hiding this comment.
I prefer to use params on only controller.
@posts has current_page method, so why don't you use @posts.current_page instead of params?
There was a problem hiding this comment.
I don't know that @posts has such method 😢 .
Could you use @posts.current_page instead of params[:page]?
Because Posts#show has canonical link to ?all page
mtsmfm
force-pushed
the
add-page-number-to-breadcrumb
branch
from
aeb8ef4
to
f40d1c6
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.