Tests: Implement additional tests for SvgImport.

bmacnaughton · Feb 11, 2016 · c0b39c4 · c0b39c4
1 parent 6797d2e
commit c0b39c4
Show file tree

Hide file tree

Showing 7 changed files with 86 additions and 16 deletions.
diff --git a/test/assets/clipping.svg b/test/assets/clipping.svg
diff --git a/test/assets/gradients-1.svg b/test/assets/gradients-1.svg
diff --git a/test/assets/gradients-2-.svg b/test/assets/gradients-2-.svg
diff --git a/test/assets/gradients-2.svg b/test/assets/gradients-2.svg
diff --git a/test/assets/viewbox.svg b/test/assets/viewbox.svg
diff --git a/test/helpers.js b/test/helpers.js
@@ -11,6 +11,7 @@
  */
 
 var isNode = typeof global === 'object',
+    isPhantom = !!window.callPhantom,
     root;
 
 if (isNode) {

diff --git a/test/tests/SvgImport.js b/test/tests/SvgImport.js
@@ -120,23 +120,48 @@ test('Import complex CompoundPath and clone', function() {
     equals(item.clone(), item, null, { cloned: true });
 });
 
-if (!isNode) {
-    test('Import SVG clipping', function(assert) {
-        importSVG(assert, 'assets/clipping.svg',
-            'The imported SVG item should visually be the same as the rasterized original SVG data.');
+function importSVG(assert, url, message, options) {
+    var done = assert.async();
+    if (!message)
+        message = 'The imported SVG "' + url + '" should visually be the same '
+            + 'as the rasterized original SVG data.';
+    project.importSVG(url, {
+        onLoad: function(item, svg) {
+            function getValue(name) {
+                return parseFloat(svg.getAttribute(name));
+            }
+            /*
+            var size = new Size(getValue('width'), getValue('height'));
+            var group = new Group({
+                children: [
+                    new Shape.Rectangle({
+                        clipMask: true,
+                        size: size
+                    }),
+                    item
+                ]
+            });
+            */
+            compareSVG(done, item, svg, message, options);
+        },
+        onError: function(error) {
+            // TODO: Implement in SvgImport first!
+            pushFailure('Loading SVG from a valid URL should not give an error.');
+            done();
+        }
     });
 }
 
-function importSVG(assert, url, message, options) {
-        var done = assert.async();
-        project.importSVG(url, {
-            onLoad: function(item, svg) {
-                compareSVG(done, item, svg, message, options);
-            },
-            onError: function(error) {
-                // TODO: Implement in SvgImport first!
-                pushFailure('Loading SVG from a valid URL should not give an error.');
-                done();
-            }
+if (!isNode) {
+    // JSDom does not have SVG rendering, so we can't test there.
+    var svgFiles = ['viewbox', 'clipping', 'gradients-1'];
+    // TODO: Investigate why Phantom struggles with this file:
+    if (!isPhantom)
+        svgFiles.push('gradients-2');
+    svgFiles.forEach(function(name) {
+        name += '.svg';
+        test('Import ' + name, function(assert) {
+            importSVG(assert, 'assets/' + name);
         });
+    });
 }