Default to edit for buffers visiting files #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deb0ch
force-pushed
the
default-to-edit-for-files
branch
from
a238772
to
1cdc59a
Compare
1 similar comment
deb0ch
force-pushed
the
default-to-edit-for-files
branch
from
1cdc59a
to
609408a
Compare
deb0ch
force-pushed
the
default-to-edit-for-files
branch
from
609408a
to
ea3c537
Compare
deb0ch
force-pushed
the
default-to-edit-for-files
branch
from
ea3c537
to
7bb45e4
Compare
deb0ch
force-pushed
the
default-to-edit-for-files
branch
from
7bb45e4
to
c401b4b
Compare
|
Hahaha, what made the test fail previously was... the other test, not the commit itself. It's all clean now, ready for proper review and merge (?). Indeed, implementing the tests was a lot harder than implementing the feature 💦 |
bmag
reviewed
Nov 5, 2017
window-purpose.el
Outdated
| @@ -165,13 +165,16 @@ This allows Purpose to work well with both `ido' and `helm'.") | |||
|
|
|||
| ;;; Overloaded commands: (C-u to get original Purpose-less behavior) | |||
| (define-purpose-prefix-overload purpose-find-file-overload | |||
| '(purpose-friendly-find-file find-file-without-purpose)) | |||
| '(purpose-friendly-find-file | |||
| find-file-without-purpose)) | |||
window-purpose.el
Outdated
|
|
||
| (define-purpose-prefix-overload purpose-find-file-other-window-overload | ||
| '(purpose-friendly-find-file-other-window find-file-other-window-without-purpose)) | ||
| '(purpose-friendly-find-file-other-window | ||
| find-file-other-window-without-purpose)) |
window-purpose.el
Outdated
|
|
||
| (define-purpose-prefix-overload purpose-find-file-other-frame-overload | ||
| '(purpose-friendly-find-file-other-frame find-file-other-frame-without-purpose)) | ||
| '(purpose-friendly-find-file-other-frame | ||
| find-file-other-frame-without-purpose)) |
window-purpose-core.el
Outdated
| @@ -212,6 +212,9 @@ If no purpose was determined, return `default-purpose'." | |||
| (purpose--buffer-purpose-mode buffer-or-name | |||
| purpose--default-mode-purposes))) | |||
|
|
|||
| ;; If the buffer is visiting a file, fallback to 'edit purpose | |||
| (when (buffer-file-name (get-buffer buffer-or-name)) | |||
| 'edit) | |||
There was a problem hiding this comment.
Should use a new custom default-file-purpose variable, which has a default value of edit.
test/core-test.el
Outdated
| (get-buffer-create "yolo") | ||
| (should (equal (purpose-buffer-purpose (get-buffer "yolo")) default-purpose)) | ||
| (kill-buffer "yolo"))) | ||
|
|
There was a problem hiding this comment.
Use unwind-protect and purpose-kill-buffers-safely. This ensures proper tear-down of the test, and separate the tear-down from what's actually being tested. See other tests in the same file for examples.
deb0ch
force-pushed
the
default-to-edit-for-files
branch
from
c401b4b
to
b8ba90c
Compare
deb0ch
force-pushed
the
default-to-edit-for-files
branch
from
b8ba90c
to
5942f70
Compare
|
All done 👌✨ |
|
I squashed your commits and made some additional fixes in 2655bbe. Thank you. |
|
Yay ! 🎉 🎊 That was a swift one, so good to see something merged so quickly right after initial discussion 😸 Nice work ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #113, implementing tests for this is still needed.
I tested it manually and
'editare still in'edit*magit: blah*still gets'generalSPC ff RET blablabla RETin Spacemacs it nicely gets'editspacemacs/new-empty-buffer) with a random name it nicely gets'general