Fix over consing #152
Merged
Fix over consing #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `cl-block` combined with `maphash` prevents creating several intermediate lists of which we only want one item. Note- `purpose--iter-hash` is no longer used, but still updated to lower consing by simply using `push` rather than appending new entries to the tail of the already-gathered-results
Fixes bmag#149 The problem is that 'gathering a list of other buffers with the same purpose' conses due to an inevitable maphash later on, and even though it's not a ton, it adds up quick because this function is called on every kill-buffer call. Even for the tons and tons of background temp buffers used by company, helm, sly, and others. The fix: We don't need to figure out the list of other buffers unless we actually come across a window that was displaying the killed buffer. So this fix just delays calculating it until we actually need it.
|
I look forward to this being merged. Emacs slows to a crawl after a short while without this. |
bmag
requested changes
Jun 28, 2019
Better backwards-compatibility and no cl-lib dependency
|
Sorry about that! e935c88 is broken because I didn't quote the |
bmag
approved these changes
Jun 28, 2019
|
Thanks a lot! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #149
The main fix is to not calculate the list of 'other buffers with same purpose' unless we're going to be replacing the buffer. This prevents calculating said list for buffers that aren't being displayed on any window, in particular, background buffers created with
with-temp-bufferand the like.Additionally, minor efficiency improvements for calculating buffer purpose are included