Fix #178: x-magit: don't override backup variable on double activation #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duianto
referenced
this pull request
in syl20bnr/spacemacs
Mar 4, 2021
problem: trying to open a magit buffer after reloading the configuration: `SPC f e R` shows the message: >Lisp nesting exceeds ‘max-lisp-eval-depth’ cause: purpose-x-magit-multi-on can't be called twice, without turning it off first: purpose-x-magit-off Spacemacs, purpose-x-magit-multi-on, Lisp nesting exceeds ‘max-lisp-eval-depth’ bmag/emacs-purpose#178 solution: in this case we'll only call: purpose-x-magit-multi-on once per Emacs session. notes: this also removes the call to: with-eval-after-load 'magit because it's handled upstream: https://github.com/bmag/emacs-purpose/blob/c85dd3c9f70cd593d6bc79c40855a240e55b2575/window-purpose-x.el#L243
duianto
added a commit
to syl20bnr/spacemacs
that referenced
this pull request
Mar 4, 2021
The upstream fix: Fix #178: x-magit: don't override backup variable on double activation by bmag bmag/emacs-purpose#179 Made it possible to just call: purpose-x-magit-multi-on
aam-at
pushed a commit
to aam-at/spacemacs
that referenced
this pull request
Mar 23, 2021
The upstream fix: Fix syl20bnr#178: x-magit: don't override backup variable on double activation by bmag bmag/emacs-purpose#179 Made it possible to just call: purpose-x-magit-multi-on
wang-d
pushed a commit
to wang-d/spacemacs
that referenced
this pull request
Jul 22, 2021
The upstream fix: Fix syl20bnr#178: x-magit: don't override backup variable on double activation by bmag bmag/emacs-purpose#179 Made it possible to just call: purpose-x-magit-multi-on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.