Toggle fixes when purpose-mode is toggled #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toggle the integration fixes on when purpose-mode is activated, and toggle them off when purpose-mode is deactivated. Mainly, this means the relevant advices are now active only while purpose-mode is active.
wyuenho
reviewed
Mar 7, 2021
| (defmacro purpose-advice-syncer (symbol where function) | ||
| "Return a function that adds or removes an advice, depending on | ||
| the value of `purpose-mode'." | ||
| `(lambda () |
There was a problem hiding this comment.
Won't calling (purpose-fix-install) again install two instances of the same hook? You should be able to memoize a hook here. i.e.
- Make a function name based on the symbol given, i.e.
(intern (format "purpose-%s-advice" symbol)) - Check for the function id'ed by the symbol's existence, if exists, return the symbol
- otherwise, make that function and return its symbol.
There was a problem hiding this comment.
Calling it twice actually won't install two instances. Both calls will return equal closures, so add-hook will treat them as equal and avoid duplicates in the hook.
There was a problem hiding this comment.
I think this is only true in emacs-27, add-hook doesn't use equal in emacs-26 and below.
|
Fixed the issues, should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggle the integration fixes on when purpose-mode is activated, and toggle them
off when purpose-mode is deactivated. Mainly, this means the relevant advices
are now active only while purpose-mode is active.
Fixes #166