stop_text_encoder_training support for LoRA network train #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @larsupb 1st, many thanks for taking the time to submit this PR. Unfortunatly it is changing a file that is own and maintained by kohya in his repo. I clone hios code into mine and use it along with the GUI. May I suggest you create a seperate PR with kohya at https://github.com/kohya-ss/sd-scripts and once he merge it in his code I could then merge your change to the GUI? Many thanks, Bernard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe discuss refactoring of LoRA callbacks network.on_epoch_start and others