-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project updates #36
Open
friederbluemle
wants to merge
15
commits into
bmarrdev:master
Choose a base branch
from
friederbluemle:update-project
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Project updates #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a Lint error.
This also removes some no-longer needed customization from build.gradle
appcompat-v7 was not needed for the library.
friederbluemle
force-pushed
the
update-project
branch
from
October 7, 2017 05:25
2208ab6
to
cf9c244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of general project cleanups and dependency cleanups.
The project now uses the latest Android Gradle plugin, and Gradle wrapper. It was updated to target SDK
25
- Note that because of this update,minSdkLevel
had to be raised to9
(it was at8
before). Please let me know if you prefer to split this PR up into multiple PRs.Once the target is switched to
26
,minSdkLevel
has to be raised all the way to14
! Let me know if you prefer to do this now, or do this at a later point (after you have published at least one update of the library). I have a local branch ready, and can force push to this PR.The project is fully compatible with the latest stable version of Android Studio (
2.3.3
).Please use a normal GitHub merge (i.e. NO rebase/squash merge) to merge the commit(s) in this pull request. The changes are broken up into meaningful, atomic commits, and my branch should already be up-to-date with the latest target branch. If it isn't, or if you'd like me to combine something, please let me know, and I will make the necessary updates as soon as possible. Thank you!