Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub action #45

Closed
wants to merge 1 commit into from
Closed

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Sep 21, 2020

Eventually, this could replace Travis. It includes a build and test check, and invokes golangci-lint with its default configuration.

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   80.55%   80.55%           
=======================================
  Files           1        1           
  Lines         432      432           
=======================================
  Hits          348      348           
  Misses         60       60           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1b336...a44867a. Read the comment docs.

@bmatcuk bmatcuk self-assigned this Sep 27, 2020
@bmatcuk
Copy link
Owner

bmatcuk commented Sep 27, 2020

Thanks for the PR, @twpayne... I haven't used github actions before - does it offer any benefits over travis?

@twpayne
Copy link
Contributor Author

twpayne commented Sep 27, 2020

The main advantages over Travis is that GitHub Actions are a lot faster, support Windows, and are under active development.

@bmatcuk
Copy link
Owner

bmatcuk commented Sep 27, 2020

FWIW, travis also supports Windows and is actively developed... but I'll concede that it's slow =) I'll take a look into github actions.

@twpayne
Copy link
Contributor Author

twpayne commented Mar 3, 2021

Closing this with ETIMEDOUT, please re-open if needed.

@twpayne twpayne closed this Mar 3, 2021
@twpayne twpayne deleted the github-actions branch March 3, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants