Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/lark/task: change the name of with_pattern and with_name #59

Closed
bmatsuo opened this issue Mar 6, 2016 · 0 comments
Closed

lib/lark/task: change the name of with_pattern and with_name #59

bmatsuo opened this issue Mar 6, 2016 · 0 comments
Labels
bug
Milestone
v0.4.0

Comments

@bmatsuo
Copy link
Owner

bmatsuo commented Mar 6, 2016

After using these functions a bit, thinking about #24 with input from #4, these names are not correct. Originally they were even called task.name and task.pattern, the change was somewhat by accident.

The name change will occur before the v0.4.0 release. Nothing in the "lark" module will change.
@bmatsuo bmatsuo added the bug label Mar 6, 2016
@bmatsuo bmatsuo added this to the v0.4.0 milestone Mar 6, 2016
bmatsuo added a commit that referenced this issue Mar 6, 2016
@bmatsuo
lib/lark/task: change the name of with_pattern and with_name
a6156da 
These names were accidental (see #59).  And when you use the decorators
it does not seem natural.
@bmatsuo bmatsuo mentioned this issue Mar 6, 2016
Merged
@bmatsuo bmatsuo closed this as completed Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
1 participant
@bmatsuo