Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

replace uuid package due to security issue #7

Closed
wants to merge 3 commits into from
Closed

replace uuid package due to security issue #7

wants to merge 3 commits into from

Conversation

missdeer
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.354% when pulling d576684 on missdeer:master into c653f95 on bmaupin:master.

@bmaupin
Copy link
Owner

bmaupin commented Aug 23, 2018

This pull request is a bit confusing because it looks like it's based on some old commits and then merged with the latest from master. I'll see if I can make sense of it anyway!

I'd been meaning to look into this because satori/go.uuid doesn't seem to be maintained. But you mentioned there's a security issue with it as well? Could you provide more details on that?

Thanks!

@missdeer
Copy link
Contributor Author

Hi,

https://github.com/satori/go.uuid has a critical defect where it doesn't generate random UUIDV4s satori/go.uuid#73 and should be replaced as the maintainer has been unresponsive for 5 months with the bug still open.
This PR just replace it with https://github.com/google/uuid.

Regards,
Fan

@bmaupin bmaupin closed this in d7a686f Aug 24, 2018
bmaupin added a commit that referenced this pull request Aug 24, 2018
@bmaupin
Copy link
Owner

bmaupin commented Aug 24, 2018

I looked into the alternative UUID libraries and settled on gofrs/uuid. It's a fork of satori/go.uuid with a bunch of issues fixed and it looks like it has more community support than google/uuid at the moment.

Thanks for your help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants