do not define mutex_R multiple times #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preprocessCore stopped building from source in Fedora rawhide as a result of moving to GCC 10. GCC 10 sets -fno-common by default, which means that variables with the same name should not be defined in multiple places in a combined code base.
In preprocessCore, "mutex_R" is defined in several places. This pull request removes the mutex_R definition from every .c file (except qnorm.c), creates a common.h which has an extern definition of mutex_R, and then #includes the common.h in all of the .c files where mutex_R was removed.
I have tested this locally and confirm that this fix resolves the build failure.