Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect when input data is too short for the sampler #95

Closed
wangyu opened this issue Jun 18, 2018 · 0 comments · Fixed by #96
Closed

Detect when input data is too short for the sampler #95

wangyu opened this issue Jun 18, 2018 · 0 comments · Fixed by #96
Assignees
@bmcfee
Labels
enhancement
Milestone
0.3.3

Comments

@wangyu
Copy link

wangyu commented Jun 18, 2018

Description

It would be nice to have pumpp be able to detect when input data is too short for the sampler to avoid ValueError.
@bmcfee bmcfee added this to the 0.3.3 milestone Jun 19, 2018
@bmcfee bmcfee self-assigned this Jun 19, 2018
bmcfee added a commit that referenced this issue Jun 19, 2018
@bmcfee
fixed #95, check data duration before sampling
d383865
@bmcfee bmcfee mentioned this issue Jun 19, 2018
Merged
bmcfee added a commit that referenced this issue Jun 19, 2018
@bmcfee
Merge pull request #96 from bmcfee/length-exception-sampler
a20c810 
fixed #95, check data duration before sampling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmcfee bmcfee

Labels
enhancement
Projects
None yet
Milestone
0.3.3
Development

Successfully merging a pull request may close this issue.

fixed #95, check data duration before sampling bmcfee/pumpp
2 participants
@bmcfee @wangyu