-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve default filters and make the whole process reproducible #96
Comments
Dear @bmcfee, I'm currently working on the packaging of resampy for debian (hope you don't mind). Do you plan to implement is in the near future? Do you have already in mind a date for the v0.3.0 release? |
Not at all - thanks for putting in the effort!
I think so, yes. I took a bit of time this afternoon to prototype a newer version of the parameter solver using optuna. (The previous version used https://github.com/craffel/simple_spearmint/ which was never properly packaged.) As it currently stands, it reliably produces filter parameters that are pretty close to what the old version did. I want to experiment with it a bit more to see if I can bring the noise down following the thread in #75, but I think this will be doable for the 0.3 release. |
Thanks for your quick reply. Would it be possible to have a copy of the data saved in txt format in the repo? |
Is that strictly necessary though? It wouldn't be a run-time dependency.
Is .npz not sufficient for this? |
The idea is that the debian package should be re-build entirely form sources in a debian environment and without any access to the interned. Not having opuna in debian is blocking in this sense.
I fear it is not. |
I think we still satisfy that requirement if the data is provided. The packaged filter coefficients are just a cache of something you could compute directly with an explicit parametrization. While I agree that it would be great in principle to have this all end-to-end, it seems way overkill IMO. They wouldn't require this for something like icons or audio excerpts, right? What makes this any different?
That also seems weird to me. It's an open format, and generally preferably to a text-based encoding (which may be lossy via float<->decimal conversion). |
Sorry, just for me to understand, Is it something that I can compute using the |
Basically yes. "kaiser_best" and "kaiser_fast" are cached versions of filters constructed by |
OK, do you have parameters used to generate "kaiser_best" and "kaiser_fast" in resampy v0.2.2? Having the parameters would completely solve my problem with the debian packaging, because I can generate the binary files during the build process with a very simple script. |
Sorry I have just realized that the parameters are already documented in the (current) docstring. |
Yeah, sorry for that - the open pr #98 documents this more fully. The precision values are stored in the data files though, so all the information is there. |
Thanks a lot @bmcfee |
Very cool - thanks! I'll also plan to have the 0.3.0 release done up soon, and the upgrade process should be pretty easy. |
yes, after the first upload in the debian archive I should be able to perform the update to new versions very quickly |
Issue #75 raised some questions about the pre-packaged default filters that we ship with, and whether they could be improved. (I expect the answer is "yes".)
Previously, the filter optimization was implemented by a gaussian process hyperparameter optimization #8 as implemented in this gist: https://gist.github.com/4aa4c959bb0d310e3f12cdedf91d7661
The above notebook worked well enough given the constraints and tools of the time, but I did have to dredge it out of an old laptop. Properly this functionality should be included in the repository, and be fully reproducible (with rng seeds and all). Doing this will make it easier to improve the filters going forward. It would also make it possible to experiment with building a larger parameter search into the process.
If we reimplement this, it probably makes sense to discuss the window design objective (a little ad-hoc at the moment) and look into more modern tooling for GP search (eg hyperopt).
The text was updated successfully, but these errors were encountered: