New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-dupe completion suggestions #843
Comments
This is only for classes, right? |
Types, functions, constants to start with. I've seen it happen with methods too. |
Are you planning to compare parameters/return (for functions) or value (for constants) to merge only the same definitions? Besides user-land collisions there is also #737 |
For completions I'm thinking that it is better to show just a single entry if the insert text is the same but show a doc section for both definitions. For example, with |
functions, constants, type de-duped in 1.3.3. Leaving open to investigate members. |
@KapitanOczywisty , I opened #933 for this. |
Sometimes there are multiple definitions in a workspace for the same type name. An example is when stub definitions are included in the workspace to supplement code that is written in a way that makes it difficult/impossible for static analysis engines to discover (eg Laravel and laravel-ide-helper). Only offer a single completion suggestion per nae in such cases.
The text was updated successfully, but these errors were encountered: