Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set signature help active signature to best match when there are multiple signatures #933

Open
bmewburn opened this issue Jan 5, 2020 · 0 comments
Milestone

Comments

@bmewburn
Copy link
Owner

bmewburn commented Jan 5, 2020

Currently arg count is the only selector here. Could expand to type checking too but when there is a type overlap on first parameter(s) then it is not helpful.

eg https://www.php.net/manual/en/function.strtr.php

strtr ( string $str , string $from , string $to ) : string
strtr ( string $str , array $replace_pairs ) : string

Updating to LSP 3.15 / node-language-server 6 which will send the user selected active signature would also solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant