Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To Improve trie tree #35

Closed
bmf-san opened this issue May 9, 2021 · 0 comments · Fixed by #36
Closed

To Improve trie tree #35

bmf-san opened this issue May 9, 2021 · 0 comments · Fixed by #36
Assignees
@bmf-san

Comments

@bmf-san
Copy link
Owner

bmf-san commented May 9, 2021 •
edited
Loading

Description

I noticed a data structure problem while considering implementing middleware for CORS.
In the current structure of the trie tree, HTTP verb matching is indispensable for routing matching.
This is inconvenient for middleware application.
There are cases where you want to apply middleware processing before determining HTTP verb matching.

Todo

Modify the data structure so that the Node has an HTTP verb.
@bmf-san bmf-san self-assigned this May 9, 2021
@bmf-san bmf-san mentioned this issue May 9, 2021
Merged
@bmf-san bmf-san linked a pull request May 10, 2021 that will close this issue
To Improve the data structure of trie tree #36
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmf-san bmf-san

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

To Improve the data structure of trie tree bmf-san/goblin
1 participant
@bmf-san