-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padding Issue in Navigation Bar #23
Comments
@bmFtZQ Can you tell anything about this ? |
The permissions button has less padding on the left so the icon can be placed closer to the site information button. |
As I said in issue #4 there isn't really an alternative as CSS selectors can only select downwards in the page layout. The site information button cannot be selected based on if the permissions button is displayed, so the only solutions I can find are:
I found that solution 2 was better than the first, so that is what the theme uses. Although I would welcome anyone to find a better solution and submit a pull request, if possible. |
Why not try using Option 2 and make a commit then ? By this atleast we don't have permissions icon in the field of Padlock. |
I think Solution 3 (more spacing) is really a good one. You should implement it in my Opinion, I think. It's better to have this instead of all other solutions. Off-Topic : Would be great if you provide the |
I have now implemented solution 3 but with solution 2 as optional (
So releasing tags/versions for each update instead of just downloading the full repository? |
Great to know.
Yeah, Because It would be easy to follow new Changes and update accordingly. Do you know of a easier way to update the CSS instead of downloading again, everytime ? |
You could use a simple script to download the theme and move it to the chrome folder automatically using macOS/Linux Shell script (.sh file): #!/bin/sh
# temp dir used to store downloaded/extracted files before copying
TEMPCHROMEDIR="/tmp/userchrome"
# find profile dir in about:profiles "root directory"
PROFILEDIR="/Users/${USERNAME}/Library/Application Support/Firefox/Profiles/xxxxxxxx.default-release"
# file to download
UPDATEURL="https://github.com/bmFtZQ/edge-frfox/archive/refs/heads/main.tar.gz"
# make temp dir
mkdir -p "$TEMPCHROMEDIR"
# download file using curl
curl -Lo "$TEMPCHROMEDIR/theme.tar.gz" "$UPDATEURL"
# extract archive into temp dir
tar -xf "$TEMPCHROMEDIR/theme.tar.gz" --strip 1 -C "$TEMPCHROMEDIR"
# remove existing chrome dir
rm -rf "$PROFILEDIR/chrome"
# copy chrome folder to profile
cp -r "${TEMPCHROMEDIR}/chrome" "$PROFILEDIR/chrome"
# remove temp dir
rm -rf "$TEMPCHROMEDIR" Windows Batch script (.bat file): @REM temp dir used to store downloaded/extracted files before copying
set TEMPCHROMEDIR=%Temp%\userchrome
@REM find profile dir in about:profiles "root directory"
set PROFILEDIR=C:\Users\%USERNAME%\AppData\Roaming\Mozilla\Firefox\Profiles\xxxxxxxx.default-release
@REM file to download
set UPDATEURL=https://github.com/bmFtZQ/edge-frfox/archive/refs/heads/main.tar.gz
@REM make temp dir
mkdir %TEMPCHROMEDIR%
@REM download file using curl
curl -Lo "%TEMPCHROMEDIR%\theme.tar.gz" "%UPDATEURL%"
@REM extract archive into temp dir
tar -xf "%TEMPCHROMEDIR%\theme.tar.gz" --strip 1 -C "%TEMPCHROMEDIR%"
@REM remove existing chrome dir
rmdir "%PROFILEDIR%\chrome\" /Q/S
@REM copy chrome folder to profile
xcopy "%TEMPCHROMEDIR%\chrome" "%PROFILEDIR%\chrome\" /E/Y
@REM remove temp dir
rmdir "%TEMPCHROMEDIR%" /Q/S So you can save the script to a file, add the profile directory (can be found in |
I think it's better to use Git for this purposes instead. Okay, What are you going to do about the Releases ? |
As, The Main Issue is solved and doing releases is dependant on you. I am closing this issue. |
I've published the first new release now.
I didn't use git for the script because that isn't installed by default on Windows and macOS. |
The Below needs to be fixed. Firefox 100, Windows 11.
The text was updated successfully, but these errors were encountered: