Sry klok import fix task #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please change tabs to 2 spaces. Team can show you how to have Sublime do that for you. |
amcates
reviewed
Jun 14, 2017
lib/tasks/fix_klok_import_data.rake
Outdated
| puts "There are " + no_of_fulfillments.to_s + " fulfillments with performer id " + old_performer_id | ||
|
|
||
| if no_of_fulfillments > 0 | ||
| new_performer_id = prompt "Enter new performer id: " |
There was a problem hiding this comment.
You might want a way to validate the IDs are actually a number. Also, I would write a log file of every fulfillment that you change. That way if an error occurs we can undo the changes quickly.
|
@amcates So... this file IS double spaced locally, I just tested it out on mine, and committed, but github still insists that it's 4 spaces. I have no idea why. Edit: Nevermind, figured it out, sublime was being TOO helpful |
|
Looks good to me. Now to get travis to pass. |
Stuart-Johnson
approved these changes
Jun 20, 2017
kayla-glick
approved these changes
Jun 20, 2017
jleonardw9
approved these changes
Jun 20, 2017
jwiel86
approved these changes
Jun 20, 2017
marklohr
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/147194985