wth - Responses Controller find_survey Logic

Find only surveys that are active. [#143259371]
bmic-development · Apr 12, 2017 · 527cd90 · 527cd90
1 parent 2905010
commit 527cd90
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/app/controllers/surveyor/responses_controller.rb b/app/controllers/surveyor/responses_controller.rb
@@ -64,7 +64,7 @@ def create
   private
 
   def find_survey
-    surveys = Survey.where(access_code: params[:access_code]).order('version DESC')
+    surveys = Survey.where(access_code: params[:access_code], active: true).order('version DESC')
 
     if params[:version]
       @survey = surveys.where(version: params[:version]).first

diff --git a/spec/controllers/surveyor/responses/get_new_spec.rb b/spec/controllers/surveyor/responses/get_new_spec.rb
@@ -31,7 +31,7 @@
     end
 
     it 'should assign @survey to the Survey' do
-      survey = create(:survey)
+      survey = create(:survey, active: true)
 
       xhr :get, :new, {
         access_code: survey.access_code
@@ -41,7 +41,7 @@
     end
 
     it 'should assign @response as a new Response of Survey' do
-      survey = create(:survey)
+      survey = create(:survey, active: true)
 
       xhr :get, :new, {
         access_code: survey.access_code
@@ -52,7 +52,7 @@
     end
 
     it 'should build question responses' do
-      survey = create(:survey)
+      survey = create(:survey, active: true)
 
       xhr :get, :new, {
         access_code: survey.access_code
@@ -63,7 +63,7 @@
 
     context 'format.html (Taking Survey From Email Link)' do
       it 'should assign @review to false' do
-        survey = create(:survey)
+        survey = create(:survey, active: true)
         org = create(:organization)
         ssr = create(:sub_service_request_without_validations, organization: org)
 
@@ -77,7 +77,7 @@
       end
 
       it 'should assign @sub_service_request' do
-        survey = create(:survey)
+        survey = create(:survey, active: true)
         org = create(:organization)
         ssr = create(:sub_service_request_without_validations, organization: org)
 
@@ -91,7 +91,7 @@
       end
 
       it 'should render template' do
-        survey = create(:survey)
+        survey = create(:survey, active: true)
         org = create(:organization)
         ssr = create(:sub_service_request_without_validations, organization: org)
 
@@ -105,7 +105,7 @@
       end
 
       it 'should respond ok' do
-        survey = create(:survey)
+        survey = create(:survey, active: true)
         org = create(:organization)
         ssr = create(:sub_service_request_without_validations, organization: org)
 
@@ -121,7 +121,7 @@
 
     context 'format.js (Taking Survey From Step 4' do
       it 'should assign @review to true' do
-        survey = create(:survey)
+        survey = create(:survey, active: true)
 
         xhr :get, :new, {
           access_code: survey.access_code,
@@ -132,7 +132,7 @@
       end
 
       it 'should render template' do
-        survey = create(:survey)
+        survey = create(:survey, active: true)
 
         xhr :get, :new, {
           access_code: survey.access_code,
@@ -143,7 +143,7 @@
       end
 
       it 'should respond ok' do
-        survey = create(:survey)
+        survey = create(:survey, active: true)
 
         xhr :get, :new, {
           access_code: survey.access_code,

diff --git a/spec/features/review/user_takes_system_satisfaction_survey_spec.rb b/spec/features/review/user_takes_system_satisfaction_survey_spec.rb
@@ -66,7 +66,7 @@
 
   context 'and system is using system satisfaction survey' do
     before :each do
-      @survey = create(:survey, access_code: 'system-satisfaction-survey', title: 'System Satisfaction Survey')
+      @survey = create(:survey, access_code: 'system-satisfaction-survey', title: 'System Satisfaction Survey', active: true)
 
       stub_const("SYSTEM_SATISFACTION_SURVEY", true)
 

diff --git a/spec/features/surveyor/user_takes_survey_spec.rb b/spec/features/surveyor/user_takes_survey_spec.rb
@@ -27,7 +27,7 @@
   fake_login_for_each_test
 
   before :each do
-    @survey   = create(:survey, title: "My Survey")
+    @survey   = create(:survey, title: "My Survey", active: true)
     @section  = create(:section, survey: @survey)
     org       = create(:organization)
     @ssr      = create(:sub_service_request_without_validations, organization: org)