Merge pull request #112 from bmic-development/wth-show-button-bug

wth - (SPARCRequest & SPARCDashboard) Additional Details 500 Error on

app/controllers/additional_details/previews_controller.rb

@@ -19,6 +19,7 @@
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.~
 
 class AdditionalDetails::PreviewsController < ApplicationController
+  before_action :authenticate_identity!
 
   def create
     @service = Service.find(params[:service_id])

app/controllers/additional_details/questionnaires_controller.rb

@@ -19,6 +19,7 @@
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.~
 
 class AdditionalDetails::QuestionnairesController < ApplicationController
+  before_action :authenticate_identity!
   before_action :find_service
   before_action :find_questionnaire, only: [:edit, :update, :destroy]
   layout 'additional_details'

app/controllers/additional_details/submissions_controller.rb

@@ -1,4 +1,5 @@
 class AdditionalDetails::SubmissionsController < ApplicationController
+  before_action :authenticate_identity!
   layout 'additional_details'
   include AdditionalDetails::StatesHelper
 

app/controllers/additional_details/update_questionnaires_controller.rb

@@ -19,6 +19,7 @@
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.~
 
 class AdditionalDetails::UpdateQuestionnairesController < ApplicationController
+  before_action :authenticate_identity!
 
   def update
     @service = Service.find(params[:service_id])

app/views/additional_details/submissions/_submission_info.html.haml

@@ -7,6 +7,9 @@
             %h4.list-group-item-heading
               = item.content
             %p.list-group-item-text
-              = qr.content.delete('[]').delete('\"')
+              - if item.item_type == 'multiple_dropdown'
+                = qr.content.delete('[]').delete('\"')
+              - else
+                = qr.content
       - unless item == @items.last
         %hr

spec/controllers/additional_details/previews/post_create_spec.rb

@@ -21,6 +21,9 @@
 require 'rails_helper'
 
 RSpec.describe AdditionalDetails::PreviewsController do
+  stub_controller
+  let!(:logged_in_user) { create(:identity) }
+
   describe '#create' do
     before :each do
       @service = create( :service )
@@ -54,4 +57,4 @@
 
     it { is_expected.to respond_with :ok }
   end
-end
+end

spec/controllers/additional_details/questionnaires/delete_destroy_spec.rb

@@ -21,6 +21,9 @@
 require 'rails_helper'
 
 RSpec.describe AdditionalDetails::QuestionnairesController do
+  stub_controller
+  let!(:logged_in_user) { create(:identity) }
+
   describe '#destroy' do
     before :each do
       @service = create(:service)

spec/controllers/additional_details/questionnaires/get_edit_spec.rb

@@ -21,6 +21,9 @@
 require 'rails_helper'
 
 RSpec.describe AdditionalDetails::QuestionnairesController do
+  stub_controller
+  let!(:logged_in_user) { create(:identity) }
+
   describe '#edit' do
     before :each do
       @service = create(:service)

spec/controllers/additional_details/questionnaires/get_index_spec.rb

@@ -21,6 +21,9 @@
 require 'rails_helper'
 
 RSpec.describe AdditionalDetails::QuestionnairesController do
+  stub_controller
+  let!(:logged_in_user) { create(:identity) }
+
   describe '#index' do
     before :each do
       @service = create(:service)

spec/controllers/additional_details/questionnaires/get_new_spec.rb

@@ -21,6 +21,9 @@
 require 'rails_helper'
 
 RSpec.describe AdditionalDetails::QuestionnairesController do
+  stub_controller
+  let!(:logged_in_user) { create(:identity) }
+
   describe '#new' do
     before :each do
       @service = create(:service)
@@ -43,4 +46,4 @@
 
     it { is_expected.to respond_with(:ok) }
   end
-end
+end

spec/controllers/additional_details/questionnaires/post_create_spec.rb

@@ -21,6 +21,9 @@
 require 'rails_helper'
 
 RSpec.describe AdditionalDetails::QuestionnairesController do
+  stub_controller
+  let!(:logged_in_user) { create(:identity) }
+
   describe '#create' do
     before :each do
       @service = create(:service)
@@ -119,4 +122,4 @@
       it { is_expected.to respond_with(:ok) }
     end
   end
-end
+end

spec/controllers/additional_details/questionnaires/put_update_spec.rb

@@ -21,6 +21,9 @@
 require 'rails_helper'
 
 RSpec.describe AdditionalDetails::QuestionnairesController do
+  stub_controller
+  let!(:logged_in_user) { create(:identity) }
+
   describe '#update' do
     before :each do
       @service = create(:service)

spec/controllers/additional_details/update_questionnaires/patch_update_spec.rb

@@ -21,6 +21,9 @@
 require 'rails_helper'
 
 RSpec.describe AdditionalDetails::UpdateQuestionnairesController do
+  stub_controller
+  let!(:logged_in_user) { create(:identity) }
+
   describe '#update' do
     before :each do
       @service        = create(:service)

spec/features/additional_details/user_activates_questionnaire_spec.rb

@@ -23,6 +23,7 @@
 RSpec.describe 'User has multiple questionnaires that can be activated', js: true do
 
   let_there_be_lane
+  fake_login_for_each_test
 
   before(:each) do
     @service = create(:service_with_ctrc_organization)

spec/features/additional_details/user_creates_an_additional_details_questionnaire_spec.rb

@@ -22,6 +22,8 @@
 
 RSpec.describe 'User creates an additional details questionnaire', js: true do
   let_there_be_lane
+  fake_login_for_each_test
+
   scenario 'successfully' do
     service = create(:service, :with_ctrc_organization)
     visit new_service_additional_details_questionnaire_path(service)

spec/features/additional_details/user_should_see_error_when_no_questions_in_form_builder_spec.rb

@@ -2,6 +2,8 @@
 
 RSpec.describe 'User should see error - no questions created', js: true do
   let_there_be_lane
+  fake_login_for_each_test
+
   scenario 'successfully' do
     service = create(:service, :with_ctrc_organization)
     visit new_service_additional_details_questionnaire_path(service)

spec/features/additional_details/user_should_see_service_questionnaires_index_spec.rb

@@ -22,6 +22,8 @@
 
 RSpec.describe 'User should see service questionnaire index', js: true do
   let_there_be_lane
+  fake_login_for_each_test
+
   scenario 'successfully' do
     service = create(:service, :with_ctrc_organization)
     questionnaire = create(:questionnaire,

spec/features/additional_details/user_should_validation_errors_item_content_spec.rb

@@ -1,6 +1,9 @@
 require 'rails_helper'
 
 RSpec.describe 'User should see validation errors on item content', js: true do
+  let_there_be_lane
+  fake_login_for_each_test
+
   scenario 'successfully' do
     service = create(:service, :with_ctrc_organization)
     visit new_service_additional_details_questionnaire_path(service)