wth - (SPARCDashboard) Saved Filters Bug #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the latest production (v2.0.0), the previous saved filters on SPARCDashboard are no longer working. This was caused by an error in the search_query scope. It was expecting a Hash but was saved as a string. I attempted first to serialize the attribute as a Hash while converting the data-type to Text, but that was giving me issues. I ended up just using the #eval method to convert to hash on ProtocolFilter#href. Also wrote a rake task to fix historical filters and wrote feature spec where a user interacts with saved searches. [#142261025]
kayla-glick
approved these changes
Mar 23, 2017
jwiel86
approved these changes
Mar 23, 2017
jleonardw9
approved these changes
Mar 23, 2017
Stuart-Johnson
approved these changes
Mar 28, 2017
Stuart-Johnson
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the latest production (v2.0.0), the previous saved filters on
SPARCDashboard are no longer working.
This was caused by an error in the search_query scope. It was expecting
a Hash but was saved as a string. I attempted first to serialize the
attribute as a Hash while converting the data-type to Text, but that was
giving me issues. I ended up just using the #eval method to convert to
hash on ProtocolFilter#href. Also wrote a rake task to fix historical
filters and wrote feature spec where a user interacts with saved
searches. [#142261025]