Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KG - Step 3 Label Changes / Removed Bootstraptable Helpers #169

Merged
merged 5 commits into from
Mar 28, 2017
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
-# Copyright © 2011-2016 MUSC Foundation for Research Development
-# All rights reserved.

-# Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

-# 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

-# 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following
-# disclaimer in the documentation and/or other materials provided with the distribution.

-# 3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products
-# derived from this software without specific prior written permission.

-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
-# BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
-# SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
-# TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
.page-header
%h3
= t(:additional_details)[:document_page_header]
Expand Down
2 changes: 1 addition & 1 deletion app/views/documents/_table.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#documents-custom-toolbar
%button.btn.btn-success#document-new{ data: { protocol_id: protocol.id } }
= t(:documents)[:add_document]
%table#documents-table{ data: { toggle: 'table', search: "true", "show-columns" => "true", "show-refresh" => "true", "show-toggle" => "true", url: documents_path(format: :json, protocol_id: protocol.id, service_request_id: service_request.id), striped: "true", toolbar: "#documents-custom-toolbar", "show-export" => "false", "export-types" => ['excel'] } }
%table#documents-table{ data: { toggle: 'table', url: documents_path(format: :json, protocol_id: protocol.id, service_request_id: service_request.id), striped: "true", toolbar: "#documents-custom-toolbar" } }
%thead.primary-header
%tr
%th{ data: { class: 'type', align: "left", sortable: "true", field: "type" } }
Expand Down
2 changes: 1 addition & 1 deletion app/views/notes/_table.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#notes-custom-toolbar
%button.btn.btn-success#note-new{ data: { notable_id: notable_id, notable_type: notable_type } }
= t(:notes)[:add]
%table.table-striped#notes-table{ data: { toggle: 'table', search: "true", "show-columns" => "true", "show-refresh" => "true", "show-toggle" => "true", url: notes_path(format: :json, note: { notable_id: notable_id, notable_type: notable_type }), striped: "true", toolbar: "#notes-custom-toolbar", "show-export" => "false", "export-types" => ['excel'] } }
%table.table-striped#notes-table{ data: { toggle: 'table', url: notes_path(format: :json, note: { notable_id: notable_id, notable_type: notable_type }), striped: "true", toolbar: "#notes-custom-toolbar" } }
%thead.primary-header
%tr
%th{ data: { class: 'user', align: "left", sortable: "true", field: "user" } }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,4 @@
.page-header
%h3
= t(:proper)[:document_management][:documents_notice]
%small
= t(:proper)[:document_management][:documents_instructions]
= render 'documents/table', protocol: service_request.protocol, permission_to_edit: true, in_dashboard: false, service_request: service_request
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,4 @@
.page-header
%h3
= t(:proper)[:document_management][:notes_notice]
%small
= t(:proper)[:document_management][:notes_instructions]
= render 'notes/table', notable_type: notable_type, notable_id: notable_id, notes: service_request.notes, in_dashboard: false
3 changes: 1 addition & 2 deletions config/locales/additional_details.en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
en:
additional_details:
additional_details_title: 'Form Functionality'
document_page_header: 'Form Functionality Submissions'
label: 'Form Functionality'
add: 'Add New Form'
preview_title: 'Form Functionality Survey Preview'
Expand Down Expand Up @@ -51,7 +50,7 @@ en:
take_additional_detail_survey: "Take Form Functionality Survey for %{service_name}"
complete_or_view: 'Complete/View'
completed: 'Completed'
document_complete_details: 'Complete Form Functionality'
document_complete_details: 'Complete Form'

submissions:
header: "Form Functionality Submissions"
Expand Down
3 changes: 1 addition & 2 deletions config/locales/proper.en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,8 @@ en:
#######################
document_management:
documents_notice: "Shared Documents"
documents_instructions: "Visible to Authorized Users and selected Service Providers"
notes_notice: "Notes"
notes_instructions: "Important notes for your Study/Project"
additional_details_notice: 'Forms'

##########
# REVIEW #
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
end

before :each do
click_link 'Complete Form Functionality'
click_link 'Complete Form'
wait_for_javascript_to_finish
end

Expand Down