Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approvals were broken by rails 5, strong params were needed [#145359963] #268

Merged
merged 1 commit into from
May 12, 2017
Merged

approvals were broken by rails 5, strong params were needed [#145359963] #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/controllers/dashboard/approvals_controller.rb
View file
Open in desktop
Expand Up @@ -27,13 +27,20 @@ def new

def create
@sub_service_request = SubServiceRequest.find(params[:ssr_id])
if @sub_service_request.update_attributes(params[:sub_service_request])
@sub_service_request.generate_approvals(@user, params[:sub_service_request])
if @sub_service_request.update_attributes(approval_params[:sub_service_request])
@sub_service_request.generate_approvals(@user, approval_params[:sub_service_request])
@service_request = @sub_service_request.service_request
@approvals = [@service_request.approvals, @sub_service_request.approvals].flatten
flash[:success] = 'Approval Submitted!'
else
@errors = @sub_service_request.errors
end
end


private

def approval_params
params.permit(:ssr_id, sub_service_request: [:nursing_nutrition_approved, :lab_approved, :imaging_approved, :committee_approved])
end
end