wth - (SPARCRequest & SPARCDashboard) Switching PI Bug #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On SPARCRequest and SPARCDashboard, when switching PIs by adding a new primary PI on the protocol, it is defaulting the previous PI to "Request/Approve Services" right, which doesn't exist any more. I updated the two classes in /lib that handle this update and set the project rights to 'approve'. [#145688447] Pivotal Story - (https://www.pivotaltracker.com/story/show/145688447) Steps to Test: 1. Find existing Protocol 2. Add a new Primary PI, which will replace the old one. 3. Proxy rights should remain as they were. updated specs
wtholt
force-pushed
the
wth-switching-pi-bug
branch
from
0d3171b
to
1d4359c
Compare
kayla-glick
approved these changes
May 22, 2017
kayla-glick
approved these changes
May 22, 2017
Stuart-Johnson
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On SPARCRequest and SPARCDashboard, when switching PIs by adding a new
primary PI on the protocol, it is defaulting the previous PI to
"Request/Approve Services" right, which doesn't exist any more.
I updated the two classes in /lib that handle this update and set the
project rights to 'approve'. [#145688447]
Pivotal Story - (https://www.pivotaltracker.com/story/show/145688447)
Steps to Test: