KG - Survey Dependency Bugs / Updates #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal Story:
https://www.pivotaltracker.com/story/show/145965119
Updates:
I updated how options are handled by questions. Currently they are not properly created/deleted for each question type. I updated it so that when changing a question type, existing options are removed. Also, if changing to a Yes/No question, because you don't add options manually, the model creates the options.
Fixing Liker scale so that it works correctly when selected as a depender question.
I updated the dependents dropdown to only include questions that come before the current question.
I updated the javascript that rerenders the dependents dropdowns. Instead of using an AJAX success with a JSON return, I simply rerender the corresponding partials using a javascript template.
@Stuart-Johnson
Ignore the commit pivotal IDs. I accidentally had the wrong story open and used the wrong IDs.