Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl additional details specs #64

Merged
merged 6 commits into from Feb 15, 2017
Merged

Conversation

jleonardw9
Copy link

Because of the bootstrap modal, the only way I could get the last test (line 38) to work was to use a sleep. Any help getting rid of this would be appreciated.

@wtholt
Copy link

wtholt commented Feb 8, 2017

@jleonardw9 I tried playing around with different ideas, none of them worked. Sleep is fine with me unless @jayhardee9 has any better ideas.

@jayhardee9
Copy link

jayhardee9 commented Feb 9, 2017

@jleonardw9 Have you tried expect(page).to have_css('#submissionModal .modal-body form') in lieu of sleep 1? I know it's a little weird to have an expectation there, but it should make Capybara wait for the modal form.

@jayhardee9
Copy link

@jleonardw9 Any luck with my suggestion?

@jleonardw9
Copy link
Author

Sorry, have not tried it yet. I will let you know.

@jleonardw9
Copy link
Author

Thanks, Jay! That worked and I just made the change.

@Stuart-Johnson Stuart-Johnson merged commit 43d9c11 into master Feb 15, 2017
@Stuart-Johnson Stuart-Johnson deleted the jl-additional-details-specs branch February 15, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants