wth - Move the Ruby Racer gem to Production group #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current locked version of the RubyRacer gem causes issues with the setup of the application. Since this gem is only needed for our production server environment as the JavaScript Runtime, we don't need to require it along with our development and test gemsets.[#139571923]
Stuart-Johnson
approved these changes
Feb 10, 2017
jleonardw9
approved these changes
Feb 10, 2017
|
I want to say Greg tried this sometime ago, and there was some problem with deployment. @amcates do you remember what happened? |
|
Yes, I believe we had an issue with it. It was moved on purpose.
From: jayhardee9 <notifications@github.com>
Reply-To: bmic-development/sparc-request <reply@reply.github.com>
Date: Monday, February 13, 2017 at 7:47 AM
To: bmic-development/sparc-request <sparc-request@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [bmic-development/sparc-request] wth - Move the Ruby Racer gem to Production group (#72)
I want to say Greg tried this sometime ago, and there was some problem with deployment. @amcates<https://github.com/amcates> do you remember what happened?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#72 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACeOUVipIUnvjS4QKGIxFCHqUsZbVZtyks5rcFDagaJpZM4L9qlx>.
…-------------------------------------------------------------------------
This message was secured via TLS by MUSC.
|
|
@jayhardee9 @bmic-development Maybe he tried removing it completely? When this gets deployed, it will still be installed on Production environments. |
|
@wtholt I checked those commits, and that's what happened. rubyracer was removed completely. So my earlier comment doesn't apply |
|
Ok, I'm on board with this then, unless @amcates has any information? |
jayhardee9
approved these changes
Feb 13, 2017
marklohr
approved these changes
Feb 13, 2017
jwiel86
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current locked version of the RubyRacer gem causes issues with the
setup of the application. Since this gem is only needed for our
production server environment as the JavaScript Runtime, we don't need
to require it along with our development and test gemsets.[#139571923]