New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KG - Dashboard Visit Groups Controller Specs / Day Validation Bug #8
KG - Dashboard Visit Groups Controller Specs / Day Validation Bug #8
Conversation
@@ -31,7 +31,17 @@ def update | |||
if @visit_group.update_attributes(visit_group_params) | |||
render nothing: true | |||
else | |||
render json: @visit_group.errors, status: :unprocessable_entity | |||
if @visit_group.day.nil? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a comment explaining what this is doing, since this is a little out of the ordinary.
@@ -102,8 +102,11 @@ test: | |||
root_url: / | |||
dashboard_link: /dashboard | |||
research_master_link: 'https://research-master-staging.musc.edu/' | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be resolved.
@visit_group = nil | ||
|
||
# This is an intruder | ||
flash[:alert] = 'You are not allowed to access that Visit Group.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be localized
before_action :find_visit_group, only: [:update, :destroy] | ||
|
||
before_action :find_visit_group, only: [:update, :destroy] | ||
before_filter :find_service_request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before_action is new syntax
@schedule_tab = params[:schedule_tab] | ||
@arm = params[:arm_id].present? ? Arm.find(params[:arm_id]) : @protocol.arms.first | ||
@visit_group = VisitGroup.new() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need parenthesis
NOTE When this is merged, please also deliver https://www.pivotaltracker.com/story/show/135552501 as requested by Wenjun |
No description provided.