Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wth - (SPARCRequest & SPARCDashboard) Display Research Master ID in #94

Merged
merged 1 commit into from Feb 17, 2017

Conversation

wtholt
Copy link

@wtholt wtholt commented Feb 16, 2017

"View Study/Project Details" and "Study Summary"

This fixes error where Research Master ID was being displayed in the
Project Summaries on Proper and Dashboard. Only should be on Studies. [#139008535]

= I18n.t('protocols.summary.na_research_master_id')
- else
= protocol.research_master_id
- if protocol.is_study?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do if protocol.is_study? && RESEARCH_MASTER_ENABLED just to be a little more space efficient

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree

= I18n.t('protocols.summary.na_research_master_id')
- else
= protocol.research_master_id
- if protocol.is_study?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

"View Study/Project Details" and "Study Summary"

This fixes error where Research Master ID was being displayed in the
Project Summaries on Proper and Dashboard. Only should be on Studies. [#139008535]
@Stuart-Johnson Stuart-Johnson merged commit 8560ec8 into master Feb 17, 2017
@Stuart-Johnson Stuart-Johnson deleted the wth-rmid-fixes branch February 17, 2017 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants