Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JWT token auth provider based on djangorestframework-simplejwt #36

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

barseghyanartur
Copy link
Contributor

As proposed/discussed in #34

@bmihelac
Copy link
Owner

bmihelac commented Jun 1, 2021

@barseghyanartur thanks for this pull request.
Code looks good but I do not have an easy way to test. Do you think it would be easiest to add to jwt to example app?

@barseghyanartur
Copy link
Contributor Author

@barseghyanartur thanks for this pull request.
Code looks good but I do not have an easy way to test. Do you think it would be easiest to add to jwt to example app?

Great! Thanks for checking. I thought tests should be sufficient, but sure - I will add a working example (later today/tomorrow) and let you know.

@barseghyanartur
Copy link
Contributor Author

@bmihelac:

Example app is updated. Please, check.

@bmihelac bmihelac merged commit 90c541f into bmihelac:master Jun 9, 2021
@bmihelac
Copy link
Owner

bmihelac commented Jun 9, 2021

@barseghyanartur merged, thanks!

@barseghyanartur
Copy link
Contributor Author

@bmihelac:

Thanks! Could a npmjs release be expected one day soon? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants